Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't handle $$ in filenames correctly #29

Closed
krainboltgreene opened this issue Apr 28, 2016 · 2 comments
Closed

Doesn't handle $$ in filenames correctly #29

krainboltgreene opened this issue Apr 28, 2016 · 2 comments

Comments

@krainboltgreene
Copy link

Ran into this error:

Uncaught TypeError: Cannot set property 'module' of undefined

Turns out there's a bug with the filenames?

screen shot 2016-04-28 at 1 57 23 am

screen shot 2016-04-28 at 1 57 28 am

screen shot 2016-04-28 at 1 57 32 am

Have you considered checksums?

@krainboltgreene
Copy link
Author

Turns out this was node-fs-extra's fault, but since it depends on it I suggest keeping this open until they fix and have an update pushed.

I also still suggest using checksums for the property names, since filenames can be really crazy.

@Macil
Copy link
Owner

Macil commented Sep 16, 2016

Nah, there was a real issue in browserify-hmr here. Turns out if you do someString.replace(foo, bar), then if bar is a string with $ characters, they get treated specially. The fix was to change bar to be a function that returns a string, which .replace doesn't do anything special with.

Fixed in browserify-hmr 0.3.2.

@Macil Macil closed this as completed Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants