Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error using --hpctype local #21

Open
afmcc opened this issue May 9, 2018 · 2 comments
Open

error using --hpctype local #21

afmcc opened this issue May 9, 2018 · 2 comments

Comments

@afmcc
Copy link
Contributor

afmcc commented May 9, 2018

iramohio-01$ tardis -q --hpctype local echo hello
Traceback (most recent call last):
File "/stash/miniconda3/envs/universal2/bin/tardis", line 6, in
sys.exit(tardis.run.tardis_main())
File "/stash/miniconda3/envs/universal2/lib/python2.7/site-packages/tardis/run.py", line 244, in tardis_main
(exit_code, factory) = run(command_args, options, checkCommandIsValid = False)
File "/stash/miniconda3/envs/universal2/lib/python2.7/site-packages/tardis/run.py", line 70, in run
job = c.gethpcJob(cmd)
File "/stash/miniconda3/envs/universal2/lib/python2.7/site-packages/tardis/conditioner/factory.py", line 550, in gethpcJob
hpcjob = self.hpcClass(self,conditioned_toolargv)
File "/stash/miniconda3/envs/universal2/lib/python2.7/site-packages/tardis/job/local.py", line 14, in init
(junk, self.shell_script_template, self.runtime_config_template) = self.get_templates(None, "local_shell", "basic_local_runtime_environment")
File "/stash/miniconda3/envs/universal2/lib/python2.7/site-packages/tardis/job/hpc.py", line 97, in get_templates
raise tutils.tardisException("error neither job_template_name nor job_template_filename are defined (and no default available")
tardis.tutils.tutils.tardisException: error neither job_template_name nor job_template_filename are defined (and no default available

@afmcc
Copy link
Contributor Author

afmcc commented Jun 20, 2018

unfortunately testing of that fix did not pick up another issue

crash$ tardis --hpctype local echo "hello"
reading config from /etc/tardis/tardis.toml
tool args = ['echo', 'hello']
tardis.py : logging this session to /home/mccullocha/tardis_Gpg9zo
Traceback (most recent call last):
File "/stash/miniconda3/envs/universal2/bin/tardis", line 11, in
sys.exit(tardis_main())
File "/stash/miniconda3/envs/universal2/lib/python2.7/site-packages/tardis/run.py", line 244, in tardis_main
(exit_code, factory) = run(command_args, options, checkCommandIsValid = False)
File "/stash/miniconda3/envs/universal2/lib/python2.7/site-packages/tardis/run.py", line 116, in run
unsentJob.sendAvailableOutput(dc.outputCollector, dc.productCollector)
File "/stash/miniconda3/envs/universal2/lib/python2.7/site-packages/tardis/job/local.py", line 281, in sendAvailableOutput
time.sleep(self.POLL_INTERVAL)
NameError: global name 'time' is not defined
crash$

@afmcc
Copy link
Contributor Author

afmcc commented Jun 20, 2018

commit c63a42f
Author: afmcc [email protected]
Date: Wed Jun 20 15:40:40 2018 +1200

another patch for issue 20. Tested and resolves bug

diff --git a/tardis/job/local.py b/tardis/job/local.py
index c183975..29fd772 100755
--- a/tardis/job/local.py
+++ b/tardis/job/local.py
@@ -1,4 +1,4 @@
-import string, os, stat, subprocess, sys, re
+import string, os, stat, subprocess, sys, re, time

import tardis.tutils.tutils as tutils
import tardis.job.hpc as hpc

  • will close when re-tested after release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant