Improve comments heuristic #389
Conversation
Nadrieril
force-pushed
the
tweak-comments
branch
from
56d438f to
17b20da
Compare
|
FYI, just gave this a quick try, and I don't seem to be receiving the comments at all anymore (or at least, the one I noticed had a problem) |
|
Yeah I marked it as draft because it doesn't work for complex cases such as destructuring or |
Nadrieril
force-pushed
the
tweak-comments
branch
from
17b20da to
d3d013c
Compare
|
This seems to be rotting. @Nadrieril do you have any plan for this PR? |
|
I was hoping to get back to it when higher-priority items are done, but tbf I don't know how to go about this. The few heuristics I tried don't work and the last idea I had required an important change to the visitors library we're using (so we can hold on to borrows while visiting) |
|
Is no one else in the Rust ecosystem doing this? (Retaining inline comments.) Should this be a discussion with upstream Rustc to add more support in the compiler itself? |
|
I don't know of anyone else doing that no |
Fixes #388.