Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update component's separator layout. #2027

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Update component's separator layout. #2027

wants to merge 7 commits into from
+5 −5

Conversation

nauaros
Copy link
Contributor

@nauaros nauaros commented Feb 26, 2025

Summary

  • Update the component's separator layout in order to be centered within the container view.
  • Pin card logo's edges to the card number field's edges.

Demo

Before Update
Simulator Screenshot - iPhone 16 Pro - 2025-02-25 at 14 38 05 Simulator Screenshot - iPhone 16 Pro - 2025-02-26 at 11 56 53

Release notes

  • Update the component's separator layout in order to be centered within the container view.
  • Pin card logo's edges to the card number field's edges.

Ticket

COIOS-000

@nauaros nauaros self-assigned this Feb 26, 2025
github-actions[bot]
github-actions bot requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@nauaros nauaros marked this pull request as ready for review February 27, 2025 09:38
@github-actions GitHub Actions
Copy link
Contributor

✅ No changes detected

Comparing fix-component-layout to develop

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@goergisn goergisn added the fixed a pull request that fixes a bug label Feb 27, 2025
@goergisn goergisn self-requested a review February 27, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmamont atmamont atmamont approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@goergisn goergisn Awaiting requested review from goergisn

@erenbesel erenbesel Awaiting requested review from erenbesel

@neelSharma12 neelSharma12 Awaiting requested review from neelSharma12

At least 3 approving reviews are required to merge this pull request.

Assignees

@nauaros nauaros

Labels
fixed a pull request that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nauaros @atmamont @goergisn