New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsure about the theta, phi -> ra, dec conversion #18

Open

martamonelli opened this issue Mar 31, 2023 · 0 comments

Contributor

martamonelli commented Mar 31, 2023

I'm a bit confused by lines 380-387 in scanning.py:

beamconv/beamconv/scanning.py

Lines 380 to 387 in e13f52e

    
           # From (theta,phi) to (ra,dec) convention 
        
           # Also, all angles are converted in degrees 
        
           ra = np.degrees(phi_out) - 180. 
        
           dec = np.degrees(theta_out) - 90. 
        
           psi = np.degrees(psi_out) 
        
           # Calculate the quaternion 
        
           q_bore = Q.radecpa2quat(ra, dec, psi)

Shouldn't the theta, phi -> ra, dec conversion be

ra = np.degrees(phi)
dec = 90. - np.degrees(theta)

Maybe there was a reason why we wrote the conversion this way, but I cannot remember. I'm writing here just in case someone does.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment