Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brightness adjustment. #41

Open
Just-another-pleb opened this issue Aug 20, 2019 · 1 comment
Open

Brightness adjustment. #41

Just-another-pleb opened this issue Aug 20, 2019 · 1 comment

Comments

@Just-another-pleb
Copy link

Without wanting to make it too complicated:

4 (5 actually?) levels of "brightness" for the LED.
I'll pick 4 as I am trying to keep it practical and a base of 2 (to maybe help with byte optimisation)
8 would be too many.
2 would be a bit too few.
4 seems like a good choice.

Levels would be (something like):
5 - FULL
4 - NOT QUITE FULL
3 - MEDIUM
2 - NOT SO DULL
1 - DULL
0 - OFF

Names are nominal. Just to explain for people to get the idea.

I know LEDs are usually ON/OFF indications.
But sometimes it may be nice to have different brightnesses. (?)

Either for dark screens/modes or to act as a progress indicator with how bright the LED is.

I know this could be done with colours. But sticking to their names: (eg)
red, green, blue, lime, yellow, (etc)
you send a message with the brightness of the LED.
FULL/MAXIMUM is the default.

Only a suggestion.

@yoiang
Copy link
Member

yoiang commented Aug 22, 2019

Hey @Just-another-pleb !
Thanks again for the suggestion! I understand where you're coming from and how this would be a great visual indicator.

My initial reactions are:

  • this is really specific, prescribed behavior that we should do a generalization thought experiment pass on to see if there is value at that level (potentially a way to map ranges of values to a range of colors rather than discretely like we have right now)
  • adding a color manipulation library as a direct dependency for this specific, prescribed behavior that only some will use seems weighty
    • perhaps instead we can come up with or leverage a set of tools for integrating any color manipulation library, or any other source, and leave it up to the user, maybe this comes from our top point ^

Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants