Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using settings.json? #135

Open
SachaG opened this issue Aug 5, 2016 · 4 comments
Open

Using settings.json? #135

SachaG opened this issue Aug 5, 2016 · 4 comments

Comments

@SachaG
Copy link

SachaG commented Aug 5, 2016

I didn't see anywhere in the docs that mentions how to use a settings.json file?

From a bit of googling it looks like this works:

heroku config:add METEOR_SETTINGS="$(cat settings.json)"

Should I make a PR to add it to the docs? or is there a better way?

@yourcelf
Copy link
Collaborator

yourcelf commented Aug 8, 2016

Good point. I don't know of any other way to get settings than the METEOR_SETTINGS environment variable.

The use of METEOR_SETTINGS is really part of the Meteor docs, not something that's particular to this buildpack -- that's why we hadn't had docs yet. But it is definitely part of what someone would need to deploy their code using this buildpack, and the additional detail with the heroku invocation would definitely be helpful.

Would accept a PR for a docs update to explain how to do this.

@markudevelop
Copy link

markudevelop commented Aug 9, 2016

@SachaG thanks for pointing this out, just faced this issue 👍 and @yourcelf thanks for the buildpack its awesome!

@RobertLowe
Copy link

@SachaG @yourcelf I maintain an old fork for some 1.2.1 apps using heroku review apps, but I found it useful to prefer METEOR_SETTINGS (for produciton/staging/etc) and fallback to settings.dev.json when METEOR_SETTINGS are missing, mostly used for building review apps

Food for though 👍 https://github.com/takecasper/meteor-buildpack-horse/blob/master/bin/compile#L118-L137

@stolinski
Copy link

Thank you @SachaG ! I needed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants