Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make initial guess handle a numpy array of points for walker starting points #273

Open
TroyGustke opened this issue Jul 19, 2022 · 2 comments

Comments

@TroyGustke
Copy link
Collaborator

TroyGustke commented Jul 19, 2022

When this feature is used after implementation, the initial guess should be in the shape (n_walkers, n_parameters)

@AdityaSavara
Copy link
Owner

o During plotting, if initial guess has multiple walkers (multi dimensional) then switch to self.UserInput.mu_prior
 This requires checking if the initial guess is a string or not.
• IN the init area, where we do the check for strings, make a comment noting that if we ever support direct multidimensional arrays for initial guesses (for multiple walkers) that we will need to change the checks in the plotting function at that time also.
• WE should just (at this time) make a helper function called “checkInitialGuessType”, and that function should return the initial guess type (string, blank [blank is zero length], single parameter set, multiple walkers parameter set, other [not supported])
 For example the below line needs to be changed:
• self.mu_guess_SimulatedOutput = simulationFunction( self.UserInput.InputParameterInitialGuess) #Do NOT use self.UserInput.model['InputParameterInitialGuess'] because that won't work with reduced parameter space requests.
 This needs to be done for every plot type that plots the initial guess (including heatmap)

@AdityaSavara
Copy link
Owner

Related card:
#285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants