Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify attributes without value in selector for html filtering rules #147

Open
anyakushin opened this issue Jan 16, 2025 · 1 comment
Assignees

Comments

@anyakushin
Copy link

There are two cases for this:

  • removing elements by matching attributes without values
  • removing elements by matching attributes by name only, no matter what their values are

So the rule:

example.org$$script[defer]

should remove the element:

<script defer data-src="url"></script>

and the rule:

example.org$$div[some_attribute]

should remove both elements:

<div some_attribute="some_value">...</div>
<div some_attribute="another_value">...</div>

Related CoreLibs task: AdguardTeam/CoreLibs#1934

@anyakushin
Copy link
Author

Also, do not forget to update versions that supports the new syntax in relevant section in Knowledge Base after implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants