Add support for $removeparam modifier

[slavaleleka]

example 1

$removeparam=_openstat
$removeparam=action_object_map
$removeparam=action_ref_map
$removeparam=utm_content

example 2

||app.mi.com/download/*?id=$removeparam=ref
||mp.weixin.qq.com^$removeparam=pass_ticket
||visit.digidip.net^$removeparam=/^(ppref|ref|pid)=/
||mvideo.ru^$removeparam=/^(_requestid|reff)=/

[bogachenko]

Hi @ameshkov, is this a bug? The ADGfW program does not allow creating a regexp with repetitions. The {2,4} construction does not work for this modifier, everything after the comma causes an error. I can only create {2}, why?
eg. $removeparam=/ref(err?al)?([a-zA-Z0-9]{2,3})?[_=]/ or $removeparam=/test[1-9]{2,4}/

[Alex-302]

Try with escaped comma - {2\,4}

[bogachenko]

Yes, it works. But why should this be written, because it completely breaks the regexp markup.
It's also not on your wiki.
In addition, this will not work in the Frenchy's extension, since the markup there corresponds to the standard.

[Alex-302]

https://adguard.com/kb/general/ad-filtering/create-own-filters/#domain-modifier - applied to all regexps in AG

[bogachenko]

That's not what I was talking about, I don't understand why you're answering the question that I didn't ask.

As far as I can tell, the ADG program was universal. The program has its own sheets, but she tries to maintain the sheets and the Frenchy's achievements. There is a clear algorithm for regexps, it does not differ, and this is the standard when the number of repetitions and the "comma" symbol are wrapped in curly brackets, there can be no extraneous characters in it and the link that you gave does not apply to my question, since it says about the non-wrapped "comma" sign.

In other words, as I said, edits have been made to the markup of the regex for the program, it differs from the standard, but there is no word about this in the wiki, plus support from the Frenchy sheets will be broken.

[bogachenko]

In regular regexp not with the removeparam modifier, a comma with a slash in wrapped brackets breaks the rule of regexps. For example, go to https://ya.ru/ and try to block it one at a time:

1. /\/nova\/[0-9a-z]{7\,8}/$image - doesn't work
2. /\/nova\/[0-9a-z]{7,8}/$image - works

You have a bug in the program, just admit it. The program with a modifier cannot respond to a regular expression in one way - ok, and without a modifier - in another way - not ok. It's just wrong, and it disrupts the program.

[scripthunter7]

@bogachenko This is not a bug, it is simply a limitation of the current syntax (dollar sign and comma are special characters in adblock syntax and used for modifier list). There are plans in the near future to eliminate the need for extra escapes in regexps to prevent misunderstandings.

Reference: AdguardTeam/tsurlfilter#121

[slavaleleka]

It's also not on your wiki.

special character escaping for $removeparam is actually mentioned in the kb:
https://uploads.adguard.org/slGBfPXuJS31USt5Ez.png
https://adguard.com/kb/general/ad-filtering/create-own-filters/#removeparam-modifier

[bogachenko]

It's also not on your wiki.

special character escaping for $removeparam is actually mentioned in the kb: https://uploads.adguard.org/slGBfPXuJS31USt5Ez.png https://adguard.com/kb/general/ad-filtering/create-own-filters/#removeparam-modifier

I was talking about a wrapped special sign, not a regular one. I chose standard regex markup as a basis, if I'm talking about wrapped, then I'm looking for what's written in the wiki for wrapped signs and of course I know that the usual ones are excluded by the backslash character.