-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$urltransform does not work the same with Mac and Windows #1508
Comments
@imTHAI Hello! Please accept our apologies for the delayed response. Could you please check if the issue persists on the latest Nightly version of AdGuard for Mac which is available via this link https://agrd.io/mac_nightly? Let us know of the results. |
@imTHAI Any news on the issue? |
What's strange is that I went back to the stable version and it didn't trigger any rules either. I tried several times. Then I got a phone call (all that to say that I was busy for a few minutes) and when I got back to my Mac, I tried one of the links again (from my clipboard) and it worked (but still with the bug for which this ticket is open). |
Please answer the following questions for yourself before submitting an issue
AdGuard version
v2.15.2.1734 and v7.19.0
Browser version
Safari 18.1.1 and Floorp 11.20.0
OS version
macOS 15.1.1 and Windows 11
Ad Blocking
AdGuard Base filter
Privacy
AdGuard Tracking Protection filter
Which DNS server do you use?
AdGuard DNS
DNS protocol
Regular
Issue Details
Hello,
I have these 5 user rules:
/^https?://(?:[a-z0-9-]+.)?(?:track.effiliation.com/servlet/effi.redir|dealabs.digidip.net/visit?url=)/$urltransform=/%3A/:/
/^https?://(?:[a-z0-9-]+.)?(?:track.effiliation.com/servlet/effi.redir|dealabs.digidip.net/visit?url=)/$urltransform=/%2F///
/^https?://(?:[a-z0-9-]+.)?(?:track.effiliation.com/servlet/effi.redir|dealabs.digidip.net/visit?url=)/$urltransform=/%3F/?/
/^https?://(?:[a-z0-9-]+.)?(?:track.effiliation.com/servlet/effi.redir|dealabs.digidip.net/visit?url=)/$urltransform=/%3D/=/
/^https?://(?:[a-z0-9-]+.)?(?:track.effiliation.com/servlet/effi.redir|dealabs.digidip.net/visit?url=)/$urltransform=/^https?://(?:[a-z0-9-]+.)?(?:effiliation.com|dealabs.digidip.net).url=([^&]).*/$1/
Rmq: Yes I have 5 rules for one domain only, because $urltransform still can't decode an url 😞
If I go on this url: https://dealabs.digidip.net/visit?url=https%3A%2F%2Fwww.carrefour.fr%2Fp%2Fvalise-caracas-55cm-4-roues-noir-delsey-3219110489859&ppref=https%3A%2F%2Fwww.dealabs.com%2F&ref=ppr-fr-1676838576
from my Mac, it triggers only2 rules:
If I access the same page under Windows it triggers 3 rules and correctly cleans the url:
Thank you,
Expected Behavior
I expect the same behavior regardless of the OS.
And I expect rules whose regex is correct to be triggered. But this is not the case under macOS.
Actual Behavior
Different behavior between windows and Mac
Correct rules not triggered (with Adguard macOS version)
The text was updated successfully, but these errors were encountered: