Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$urltransform does not work the same with Mac and Windows #1508

Open
3 tasks done
imTHAI opened this issue Nov 27, 2024 · 5 comments
Open
3 tasks done

$urltransform does not work the same with Mac and Windows #1508

imTHAI opened this issue Nov 27, 2024 · 5 comments
Assignees

Comments

@imTHAI
Copy link

imTHAI commented Nov 27, 2024

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

v2.15.2.1734 and v7.19.0

Browser version

Safari 18.1.1 and Floorp 11.20.0

OS version

macOS 15.1.1 and Windows 11

Ad Blocking

AdGuard Base filter

Privacy

AdGuard Tracking Protection filter

Which DNS server do you use?

AdGuard DNS

DNS protocol

Regular

Issue Details

Hello,

I have these 5 user rules:
/^https?://(?:[a-z0-9-]+.)?(?:track.effiliation.com/servlet/effi.redir|dealabs.digidip.net/visit?url=)/$urltransform=/%3A/:/
/^https?://(?:[a-z0-9-]+.)
?(?:track.effiliation.com/servlet/effi.redir|dealabs.digidip.net/visit?url=)/$urltransform=/%2F///
/^https?://(?:[a-z0-9-]+.)?(?:track.effiliation.com/servlet/effi.redir|dealabs.digidip.net/visit?url=)/$urltransform=/%3F/?/
/^https?://(?:[a-z0-9-]+.)
?(?:track.effiliation.com/servlet/effi.redir|dealabs.digidip.net/visit?url=)/$urltransform=/%3D/=/
/^https?://(?:[a-z0-9-]+.)?(?:track.effiliation.com/servlet/effi.redir|dealabs.digidip.net/visit?url=)/$urltransform=/^https?://(?:[a-z0-9-]+.)?(?:effiliation.com|dealabs.digidip.net).url=([^&]).*/$1/

Rmq: Yes I have 5 rules for one domain only, because $urltransform still can't decode an url 😞

If I go on this url: https://dealabs.digidip.net/visit?url=https%3A%2F%2Fwww.carrefour.fr%2Fp%2Fvalise-caracas-55cm-4-roues-noir-delsey-3219110489859&ppref=https%3A%2F%2Fwww.dealabs.com%2F&ref=ppr-fr-1676838576

from my Mac, it triggers only2 rules:
Capture d’écran 2024-11-25 à 15 55 56
Capture d’écran 2024-11-25 à 16 04 30

If I access the same page under Windows it triggers 3 rules and correctly cleans the url:
Capture d’écran 2024-11-25 à 15 56 53
Capture d’écran 2024-11-25 à 16 06 14

Thank you,

Expected Behavior

I expect the same behavior regardless of the OS.
And I expect rules whose regex is correct to be triggered. But this is not the case under macOS.

Actual Behavior

Different behavior between windows and Mac
Correct rules not triggered (with Adguard macOS version)

@imTHAI imTHAI added the Bug label Nov 27, 2024
@imTHAI imTHAI changed the title $utlrtransform does not work the same with Mac and Windows $urltransform does not work the same with Mac and Windows Nov 27, 2024
@adguard-bot adguard-bot assigned AlexandrPkhm and unassigned Aydinv13 Nov 28, 2024
@AlexandrPkhm
Copy link
Contributor

@imTHAI Hello!

Please accept our apologies for the delayed response. Could you please check if the issue persists on the latest Nightly version of AdGuard for Mac which is available via this link https://agrd.io/mac_nightly?

Let us know of the results.

@AlexandrPkhm
Copy link
Contributor

@imTHAI Any news on the issue?

@imTHAI
Copy link
Author

imTHAI commented Dec 6, 2024

My sincerest apologies for the delay, especially as I have great admiration for you, the Adguard developers, and I love all your products. (I've been busy getting ready for a big trip coming up.)

It looks worse. Now it doesn't trigger any rules at all. Unless the syntax has changed and I need to adapt my rules to this new build?
I'm on V2.16.0.1856 nightly

image

@imTHAI
Copy link
Author

imTHAI commented Dec 6, 2024

What's strange is that I went back to the stable version and it didn't trigger any rules either. I tried several times. Then I got a phone call (all that to say that I was busy for a few minutes) and when I got back to my Mac, I tried one of the links again (from my clipboard) and it worked (but still with the bug for which this ticket is open).
Anyway, all that to say that I'm going to try again with the nightly release and I'll be back to comment.

@imTHAI
Copy link
Author

imTHAI commented Dec 6, 2024

Voilà, with the night release it did trigger the rules, but still not the last one. (I then tried again under Windows and it's still OK.)
Capture d’écran 2024-12-06 à 16 47 45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants