Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thesaurus.com #50888

Closed
adguard-bot opened this issue Mar 4, 2020 · 4 comments
Closed

thesaurus.com #50888

adguard-bot opened this issue Mar 4, 2020 · 4 comments

Comments

@adguard-bot
Copy link

Issue URL (Annoyance)

https://www.thesaurus.com/browse/test?s=t

Comment

The problem isn't with a specific website, but I couldn't figure out how to submit a bug report otherwise.

I just updated all my adguard filters, and now whenever I have "Web Annoyances Ultralist" turned on, no pages of any kind will load. When I turn it off, all pages start loading a few seconds later.

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information value
Platform: Ext
AdGuard version: 1.6.4
Browser: Safari
Filters: Ad Blocking:
AdGuard Base

Annoyances:
AdGuard Annoyances,
Web Annoyances Ultralist,
Adblock Warning Removal List,
I don't care about cookies,
EasyList Cookie List
Other extensions used: 1password, OKTA
@BlazDT
Copy link
Contributor

BlazDT commented Mar 4, 2020

Not seeing a rule which blocks the mentioned one. Please note the mentioned filter is a third-party filter, so we cannot do any modifications to them.
Please check @yourduskquibbles

@stale stale bot removed the A: Won't fix label Mar 4, 2020
@BlazDT BlazDT closed this as completed Mar 4, 2020
@yourduskquibbles
Copy link

yourduskquibbles commented Mar 4, 2020

Sorry this was a typo in Web Annoyances Ultralist caused by just the letter t being treated as a network filter in Adguad and blocking anything with the letter t in the URL (initial commit). This was fixed with yourduskquibbles/webannoyances@713a91a at 23:59 2020-03-03 EST (9 hours ago or so) about 4 hours after the bad filter was initially committed.

It is possible some users updated their lists between the few hours the bug filter t was present and then stuck with it until Adguard updated the cached list it fetches but it should be fixed now if users update their filters.

Sidenote: uBO was throwing out this filter t as invalid so I didn't realize the damage it was doing for Adguard users. In future maybe Adguard can also throw away such 1 letter filters in the future the same way as uBO handles them? @ameshkov

Related: yourduskquibbles/webannoyances#201

@ameshkov
Copy link
Member

ameshkov commented Mar 4, 2020

Hm, we actually discard filters that are shorter than 3 characters (at least I always thought we do that)

@Alex-302 @BlazDT could you please check it?

@yourduskquibbles
Copy link

Hm, we actually discard filters that are shorter than 3 characters (at least I always thought we do that)

@Alex-302 @BlazDT could you please check it?

t was definitely getting used as a network filter with Adguard on Chrome for Windows and was blocking all content (that contained the letter t) from loading on pages when I tested last night after being alerted in yourduskquibbles/webannoyances#201

Creating a user rule filter @@t override the bad filter t that was getting loaded from ultralist.txt but that 1 character filter was definitely being parsed by Adguard on Chrome for Windows last night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants