Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing abort typing for onSelect #1064

Open
acdn-tsmith opened this issue Jan 9, 2024 · 0 comments · May be fixed by #1109
Open

missing abort typing for onSelect #1064

acdn-tsmith opened this issue Jan 9, 2024 · 0 comments · May be fixed by #1109

Comments

@acdn-tsmith
Copy link

I have run across a typing issue when trying to consume the abort helper #918 with a multi select table. It doesn't appear that the typings have been updated: https://github.com/Addepar/ember-table/blob/master/types/components/ember-tbody/component.d.ts

I am using 5.0.6.

This is the error message I get.

Type '(selection: BlahModel | BlahModel[], { abort }: { ...; }) => void' is not assignable to type '(rows: BlahModel | BlahModel[]) => void'.
  Target signature provides too few arguments. Expected 2 or more, but got 1.

Thanks!
@acdn-tsmith acdn-tsmith changed the title abort typing for onSelect missing abort typing for onSelect Jan 9, 2024
lukasnys added a commit to lukasnys/ember-table that referenced this issue Jul 10, 2024
@lukasnys
fix(ts): add options object with abort for onSelect
bdc6b6e 
fixes Addepar#1064
@lukasnys lukasnys linked a pull request Jul 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ts): add options object with abort for onSelect lukasnys/ember-table
1 participant
@acdn-tsmith