Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace our custom drag&drop code with egui's API for it #234

Open
Adanos020 opened this issue Apr 2, 2024 · 0 comments
Open

Replace our custom drag&drop code with egui's API for it #234

Adanos020 opened this issue Apr 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Adanos020
Copy link
Owner

Is your feature request related to a problem? Please describe.
Having this feature implemented manually comes with a lot of problems. Not only does it make the whole codebase a lot more complicated, but it's also prone to breaking changes from egui. One such breaking change was introduced in egui 0.26 where the user interaction logic was rewritten, leading to recurring bugs like #226 that are hard to track down.

Describe the solution you'd like
Ideally, have all of our d&d logic removed and use the API provided by egui instead. Realistically, some bits and pieces would have to remain for proper handling of tab drops, but all of the input handling should be done by egui.

@Adanos020 Adanos020 added the enhancement New feature or request label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant