Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP options specification incomplete #194

Open
rssen opened this issue Mar 27, 2020 · 2 comments
Open

IP options specification incomplete #194

rssen opened this issue Mar 27, 2020 · 2 comments
Labels

Comments

@rssen
Copy link
Contributor

rssen commented Mar 27, 2020

There is no support for an option "x00" (which is a valid option "End of Option List" according to RFC 791 p. 16). This is used at the end of all options, not the end of each option, and need only be used if the end of the options would not otherwise coincide with the end of the internet header.

ipv4.rflx:

Option_Number : Option_Number
            then null
               if Option_Class = Control and Option_Number = 1,
            then Option_Length
               if Option_Number > 1;

            what if Option_Number = 0?

This problem occurred while rewriting the spark tests for python. (Method Test_Parsing_IPv4_With_Options in rflx_ipv4_tests.adb).

@treiher
Copy link
Collaborator

treiher commented Mar 27, 2020

Sequences with end marker are not yet supported (#61). Therefore the test case mentioned above (Test_Parsing_IPv4_With_Options) is currently disabled.

@treiher
Copy link
Collaborator

treiher commented Oct 30, 2020

Moved to Componolit/RecordFlux-specifications#6.

@treiher treiher closed this as completed Oct 30, 2020
@treiher treiher reopened this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants