Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of image size. #14

Closed
MGriot opened this issue May 17, 2023 · 1 comment · Fixed by #27 or #22
Closed

Improvement of image size. #14

MGriot opened this issue May 17, 2023 · 1 comment · Fixed by #27 or #22
Labels
category/new feature The feature will be added priority/normal Will be fixed in several iterations triage/confirm Accepted issue

Comments

@MGriot
Copy link

MGriot commented May 17, 2023

What would you like to be added?

It would be nice if you could choose the standard size of the bonds. Let me explain better, the plugin is fantastic but I find the image size option inconvenient. It doesn’t adapt well for all molecules, especially if they have different sizes. It would be more useful to be able to choose the standard size of bonds or atoms, in this way all molecules would be on the same scale. I imagine that as a request it is complicated but it would be nice to have this function.
Maybe you could directly insert the choice of the image size and whether to standardize the size of the bonds and atoms in the codeblock, in order to make it more adaptive.

Why is this needed?

This would allow for better integration into obsidian notes by avoiding having very small molecules that are impossible to read if they are too large

@MGriot MGriot added the triage The issue needs to be triaged label May 17, 2023
@Acylation Acylation added category/new feature The feature will be added triage/confirm Accepted issue priority/normal Will be fixed in several iterations and removed triage The issue needs to be triaged labels May 17, 2023
@Acylation Acylation self-assigned this May 17, 2023
@Acylation Acylation moved this to 📋 Backlog in Obsidian Chem Roadmap May 17, 2023
@Acylation
Copy link
Owner

Acylation commented May 17, 2023

I did some experiment and found that this could be easily solved by changing default 'scale' option from zero to a value, rather than explicit assigning imgWidth.

image

However, as shown in the screenshot, there are some typography problems need to be solved. I'll try to use table element to format this.

Another problem is, the structures are now rendered in png format, this would lead to low resolutions. Changing to svg may be helpful.

image

@Acylation Acylation moved this from 📋 Backlog to 🏗 In progress in Obsidian Chem Roadmap May 23, 2023
@Acylation Acylation moved this from 🏗 In progress to 👀 In review in Obsidian Chem Roadmap Jul 5, 2023
@Acylation Acylation linked a pull request Jul 13, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Obsidian Chem Roadmap Jul 13, 2023
@Acylation Acylation removed their assignment Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/new feature The feature will be added priority/normal Will be fixed in several iterations triage/confirm Accepted issue
Projects
Status: Done
2 participants