-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make orca an official dependency #437
Comments
I think @jpn-- is going to do this? |
A few seconds looking at the commit referenced above, it appears that @toliwaga maybe actually did most of this already; orca.py's gone from the repo now. I'll check more carefully soon and make sure our dependencies are installing correctly and everything, but my guess is it's good as travis is still passing. |
on further review, it looks like orca came back in 5a52dda, probably unintentionally. I'll cut it out again. |
Not unintentionally. If orca is in the environment, it is used, otherwise
core/orca.oh is used.
If you remove core/orca you should also remove the code (in inject amd
pipeline) that supports the two options.
|
Sorry - I meant to say:
If orca is in the environment, it is used, otherwise core/orca.py is used.
|
this is in #455 |
Moving forward let's make the BSD-3 licensed orca an official dependency
The text was updated successfully, but these errors were encountered: