fix: Optimize use of hash tables in platform adapters #485
+40
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I planned to do this after I changed
accesskit_consumer
to usehashbrown
. I haven't bothered to do this foraccesskit_atspi_common
oraccesskit_unix
, since interoperability with zbus is a concern for these crates, and the cumulative binary size of the Unix adapter is already quite big.Also, for the macOS adapter, I decided that using a hash table to keep track of view subclasses was overkill, since the number of items will always be small, and lookup will be rare. So I decided to favor simplicity and minimal code size instead, by using a
Vec
with linear search. The other reason to revisit this was to eliminate the dependency ononce_cell
.