-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extrinsic RPC subscription events are capitalized #304
Comments
I will put this as "won't fix" for now until one of those happens:
|
There is no spec for these old methods, but Substrate nodes and now Smoldot will return the non-capitalised event names, so shouldn't chopsticks align with these? A compatibility issue at present is with Subxt, which understands the smoldot/substrate based camelCase event names and fails for the uppercase names emitted by chopsticks (Rust being more strict on these sorts of things). We can patch Subxt to support this inconsistency, but it would be better for no inconsistency to exist at all imo :) Side note: there is a spec for the new RPC methods, and the new version of this subscription will also use camelCase names: https://paritytech.github.io/json-rpc-interface-spec/api/transaction_unstable_submitAndWatch.html |
we can fix this if it is causing trouble for subxt |
This is inconsistent with the Polkadot RPC
In Polkadot the
ready
,inBlock
,finalized
subscription event keys are not capitalizedUsing chopsticks these event keys are
Ready
,InBlock
, `FinalizedThe text was updated successfully, but these errors were encountered: