New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transmission support for generalized_schlick_bsdf #713

Closed

niklasharrysson opened this issue Oct 7, 2021 · 1 comment

Contributor

niklasharrysson commented Oct 7, 2021

The generalized_schlick_bsdf node is missing support for transmission in GLSL and OSL.

Marked with TODO's in code here:
https://github.com/materialx/MaterialX/blob/main/libraries/pbrlib/genglsl/mx_generalized_schlick_bsdf.glsl#L41
https://github.com/materialx/MaterialX/blob/main/libraries/pbrlib/genosl/mx_generalized_schlick_bsdf.osl#L6

For MDL it's already supported.

Linking this issue to the following PR in glTF that reported this problem:
KhronosGroup#1

The text was updated successfully, but these errors were encountered:

Member

jstone-lucasfilm commented May 7, 2022

Thanks for this report, @niklasharrysson, and this has been addressed in #918 (GLSL) and #934 (OSL).

jstone-lucasfilm closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment