Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in Graph::propertyEditor due to absence of null check #1600

Closed
eytienne opened this issue Nov 17, 2023 · 0 comments · Fixed by #1601
Closed

Crash in Graph::propertyEditor due to absence of null check #1600

eytienne opened this issue Nov 17, 2023 · 0 comments · Fixed by #1601

Comments

@eytienne
Copy link
Contributor

eytienne commented Nov 17, 2023 •
edited
Loading

I reproduced with the following steps:

  1. Open some simple mtlx containing a nodegraph.
  2. Click on the nodegraph to select it then doubleclick to open it.
  3. Click on a surfaceshader node.
  4. Click on the name property editor and press Backspace to drop some chars. Immediate seg fault!

Using gdb, I find out the null pointer problem causing crash in some shared_ptr code. I have the incoming PR.

Found while experimenting with #1596.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed null check in Graph::propertyEditor eytienne/MaterialX
1 participant
@eytienne