Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Editor: Scroll wheel zooms and scrolls property editor #1214

Closed
kwokcb opened this issue Feb 1, 2023 · 5 comments
Closed

Graph Editor: Scroll wheel zooms and scrolls property editor #1214

kwokcb opened this issue Feb 1, 2023 · 5 comments

Comments

@kwokcb
Copy link
Contributor

kwokcb commented Feb 1, 2023

A minor nitpick. When the editor has a scroll bar on the right (show all inputs for std surface), if you use the scroll
wheel it will zoom in / out on the preview window but also scroll at the same time so it makes it hard to be able to zoom.

zoom.mp4

Looks like some minor pointer focus / handling issue that the event once handled by the preview window should not be passed onwards back to the scrollbar ?

@lfl-eholthouser
Copy link
Contributor

Thanks for pointing this out @bernardkwok ! The render view zoom only checks right now if the cursor is within the bounds of the render view window which is causing that issue.

@pixelsandpointers
Copy link

I can try this one. Just for clarification, do we want to separate scrolling behavior for the attribute list and for the render view?

@kwokcb
Copy link
Contributor Author

kwokcb commented Jul 18, 2023

There are 3 scroll areas. The entire panel, the renderview, and just the attribute list. Each should trigger different behaviour. Only the panel scroll bar seems to affect the renderview.

@pixelsandpointers
Copy link

Thanks @kwokcb I'll take a look.

@jstone-lucasfilm jstone-lucasfilm changed the title MaterialXEditor: Minor -- scroll wheel zooms and scrolls property editor Graph Editor : Scroll wheel zooms and scrolls property editor Sep 12, 2023
@jstone-lucasfilm jstone-lucasfilm changed the title Graph Editor : Scroll wheel zooms and scrolls property editor Graph Editor: Scroll wheel zooms and scrolls property editor Sep 26, 2023
@jstone-lucasfilm
Copy link
Member

Thanks to @kwokcb for reporting this issue, and to @HudsonHN for the fix in #1578!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants