Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window is too tall for 13" MacBook Air #23

Closed
alinnert opened this issue Nov 6, 2024 · 14 comments
Closed

Window is too tall for 13" MacBook Air #23

alinnert opened this issue Nov 6, 2024 · 14 comments
Assignees
Labels
enhancement New feature or request

Comments

@alinnert
Copy link

alinnert commented Nov 6, 2024

As the title says: the app doesn't fit on the screen and I cannot resize it vertically.

@Abdenasser
Copy link
Owner

will push a fix for that in the next release, thanks for reporting @alinnert

@Abdenasser Abdenasser self-assigned this Nov 6, 2024
@Abdenasser Abdenasser added the enhancement New feature or request label Nov 6, 2024
@laciferin2024
Copy link
Contributor

I m using 13.6" its fitting as expected @alinnert . Would u mind sharing a screenshot?

@Abdenasser
Copy link
Owner

maybe he has more cpu cores than you do, which might cause the stats bar to take more vertical space than expected, I'm thinking there should be a way to collapse the stats bar somehow

@laciferin2024
Copy link
Contributor

there is enough space for 16 cores max for 13'.

@alinnert
Copy link
Author

alinnert commented Nov 7, 2024

Sure, here's a screenshot. I can make the window bigger but not smaller.

CleanShot 2024-11-07 - 001184

@laciferin2024
Copy link
Contributor

I think its a resolution issue. Which resolution are u on?

image

@laciferin2024
Copy link
Contributor

image

@alinnert
Copy link
Author

alinnert commented Nov 7, 2024

I can't make screenshots right now but I've looked it up. It's the default resolution. Also, I'm using a M1 MacBook Air. It doesn't have a notch yet, if that makes some difference.

I've also noticed that there are fewer entries in the list inside the viewport in the screenshot by @laciferin2024.

@laciferin2024
Copy link
Contributor

THe second screenshot is resized to the smallest size i can get it to be.

I use the highest res not the default res

@Abdenasser
Copy link
Owner

Abdenasser commented Nov 7, 2024

@alinnert we have these constraint
"minWidth": 1280,
"minHeight": 900
you can maybe open a PR based on what you feel should be good enough for small screens based on your testing

@laciferin2024
Copy link
Contributor

Sure, here's a screenshot. I can make the window bigger but not smaller.

CleanShot 2024-11-07 - 001184

I tried a couple of res myself, its resizing for me. I m using Sequoia b.t.w

@phillipthelen
Copy link
Contributor

As a test I set the minimum sizes to 1280 width and 400 height.

Screenshot 2024-11-08 at 11 33 21

The width currently can't be smaller, because the table title bar breaks quickly. The height of 400 obviously is not the most useful size, but does work without breaking the UI, since the table can be scrolled. Which is what I would expect from a minimum size of a UI. I think this would make a reasonable minimum size that should definitely fix the issue described here.

@alinnert
Copy link
Author

alinnert commented Nov 8, 2024

I totally agree with @phillipthelen. You can make most windows extremely small. This can still be useful though if you dock NeoHTop to the top or bottom of the screen and you only want to e.g. keep an eye on CPU usage and memory.

@Abdenasser
Copy link
Owner

should be available in next release (v1.0.9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants