Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add parameter to vanilla-specs to support locust --stop-timeout #49

Closed
aleks-vodolazko opened this issue Oct 25, 2023 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation New feature New feature or request

Comments

@aleks-vodolazko
Copy link
Contributor

aleks-vodolazko commented Oct 25, 2023

Is your feature request related to a problem? Please describe.
Sometimes some conditions/operations should be executed before launching the on_stop method when timeout is reached.
Example:

        with client.request(your_args, catch_response=True) as resp:
            if resp.status_code == 200:
                self.foo += 1    // This action will be ignored if run-time timeout is fired before the response is received. 
                resp.success()
            else:
                resp.failure()

Describe the solution you'd like
This type of issue can be handled by adding a special timeout to finish the current task execution.
Locust has a special flag to set -s STOP_TIMEOUT, --stop-timeout. It could be 0 by default, but it would be great to have it configurable.

Describe alternatives you've considered
If we can have an additional field in .yaml file such as "customParameters" or "customFlags" or "additionalFlags" that will be added at the end of the locust launching command - it would provide full support of all locust flags.

Additional context
locustio/locust#1099

@AbdelrhmanHamouda AbdelrhmanHamouda added documentation Improvements or additions to documentation New feature New feature or request labels Oct 25, 2023
@AbdelrhmanHamouda
Copy link
Owner

This is a valid use case and would be a welcomed addition to the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation New feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants