Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester A] addpa command allows adding of duplicate public addresses #264

Closed
soc-se-bot opened this issue Nov 8, 2024 · 1 comment
Closed

[PE-D][Tester A] addpa command allows adding of duplicate public addresses #264

soc-se-bot opened this issue Nov 8, 2024 · 1 comment
Assignees
@chongtzezhao

Comments

@soc-se-bot
Copy link

Running addpa 4 c/BTC l/savings_wallet pa/0x71C7656EC7ab88b098defB751B7401B5f6d8976F and then running addpa 5 c/BTC l/savings_wallet pa/0x71C7656EC7ab88b098defB751B7401B5f6d8976F allows me to add the same public address to multiple contacts. I feel like a check could be put in place to ensure that duplicate public addresses are not used since two wallets cannot have the same public address!

Screenshot 2024-11-08 at 6.03.49 PM.png

Labels: type.FeatureFlaw severity.Medium
original: Haris-Irfan/ped#12
@chongtzezhao
Copy link

Fixed in #272

@chongtzezhao chongtzezhao mentioned this issue Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chongtzezhao chongtzezhao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chongtzezhao @soc-se-bot