Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Model and ModelManager #35

Closed
CornCobs opened this issue Mar 10, 2020 · 1 comment
Closed

Update Model and ModelManager #35

CornCobs opened this issue Mar 10, 2020 · 1 comment
Assignees
Labels
priority.High Must do type.Chore Not features, but necessary jobs
Milestone

Comments

@CornCobs
Copy link

CornCobs commented Mar 10, 2020

HireLah! has a totally different model from AddressBook, thus Model needs to change.
Specifically, it needs to:

  1. Contain IntervieweeList, AttributeList, QuestionList and Metrics
  2. Provide a finalize method which when called, makes AttributeList and QuestionList unmodifiable (Should add a boolean flag to these classes)
  3. Contain a mode flag which indicates which mode the app is in, affecting the types of commands that can be given. Modes are Normal mode and interviewing mode

Implementation wise, I think it is ok for ModelManager to simply expose the components, so Commands execute on the components themselves rather than through wrapper methods exposed by Model

@bscrow
Copy link

bscrow commented Mar 17, 2020

Resolved in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Chore Not features, but necessary jobs
Projects
None yet
Development

No branches or pull requests

2 participants