Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG Review by Tutor #170

Open
sinhayash opened this issue Apr 4, 2020 · 0 comments
Open

DG Review by Tutor #170

sinhayash opened this issue Apr 4, 2020 · 0 comments

Comments

@sinhayash
Copy link

Overall you need to put more effort. You have put good effort in creating Use Cases. I have added my comments section-wise.

  • [2.2] This diagram appears very complicated. Consider having another diagram with sub-components instead of having a diagram for the entire UI component.

Screenshot 2020-04-04 at 8 28 40 PM

  • [3.1] The undo/redo feature appears as an exact replica of AB3. If you have this feature, update object names/diagrams to suit to your implementation. How do you differentiate between AB3 and this apart from refactoring?

  • [3.1] and Fig. 6
    Once the object is deleted should not continue lifeline
    Screenshot 2020-04-04 at 8 46 14 PM

Screenshot 2020-04-04 at 8 44 37 PM

  • [3.2] Appears incomplete. How are you going to not violate the constraint of human-editable file storage?

  • [3] Section 3 as a whole appears unchanged. Why have you updated it? You should explain your features along with design decisions.

  • [Appendix A] No change.
    Screenshot 2020-04-04 at 8 42 06 PM

  • [Appendix 2] Is it testable? If yes, how?
    Screenshot 2020-04-04 at 8 48 55 PM

Can you define easy to use, so that it is testable?
Screenshot 2020-04-04 at 8 49 56 PM

Why this is a requirement? What does it add to value proposition?
Screenshot 2020-04-04 at 8 50 00 PM

How to test this?
Screenshot 2020-04-04 at 8 50 13 PM

  • [Appendix E] Glossary not updated.
    Screenshot 2020-04-04 at 8 52 20 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant