Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement linking Loan to Person and Stock #262

Closed
cyanoei opened this issue Oct 29, 2019 · 0 comments · Fixed by #361
Closed

Implement linking Loan to Person and Stock #262

cyanoei opened this issue Oct 29, 2019 · 0 comments · Fixed by #361
Assignees
@cyanoei
Labels
type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Milestone
v1.4

Comments

@cyanoei
Copy link

cyanoei commented Oct 29, 2019

Required before #232 and #233.
This ensures that

  1. Loans always correspond to a valid Person and a valid Stock
  2. Loans are able to access the properties of the Person and Stock, in particular to get and update the Stock's quantity.
  3. (Less important for now) Loans can produce user-friendly print statements by printing the student's name and stock's name, rather than matric number and stock code.
@cyanoei cyanoei added the type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Oct 29, 2019
@cyanoei cyanoei added this to the v1.3 milestone Oct 29, 2019
@cyanoei cyanoei self-assigned this Oct 29, 2019
@nus-pe-script nus-pe-script mentioned this issue Oct 31, 2019
Closed
17 tasks
@cyanoei cyanoei modified the milestones: v1.3, v1.4 Oct 31, 2019
This was referenced Nov 1, 2019
Closed
Merged
@nus-pe-script nus-pe-script mentioned this issue Nov 7, 2019
Open
18 tasks
@nus-pe-script nus-pe-script mentioned this issue Nov 15, 2019
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyanoei cyanoei

Labels
type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Loans update cyanoei/eggventory-team
1 participant
@cyanoei