-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Highres Fix' option for img2img as well as txt2img #2213
Comments
highres fix is img2img it takes the img gens at a smaller res and then upscales with img2img you can already do this with img2img just take the img your generating use the same or similar prompt reduce denoising rate then change resolution and you will effectively have a highresfix |
Not quite that straightforwards, but it's also not clear if an actual 'Highres Fix' run inside img2img would actually be any better than what you describe, could certainly be an interesting test. |
The only tricky thing Highres Fix does is calculates proper low-res dimensions according to your target resolution: stable-diffusion-webui/modules/processing.py Lines 518 to 525 in 42bf5fa
For example, if you want to manually apply hr_fix-alike behavior for 800*600 image, you will need to calculate this: (paste in browser JS-console, for example)
It gives I pre-calculated useful dimension ratios for myself, sorted by increasing area discrepancy: (for vertical orientation, swap the numbers)
|
|
This would be majorly helpful. I'm not entirely sure the internal details, but using img2img on resolutions above 512x512 has a strong tendency to produce multiple heads, stacked bodies, etc similar to using txt2img without highresfix. I primarily use img2img at very high denoising strength mainly just to sample an image's color pallet. Having a way to get highres results without the typical warping would be wonderful, whether that's a highresfix checkbox or loopback. |
We definitely need a fix for img2img. I use img2img to basically add more details to an lower res image by setting "everything to 50%" and it works perfectly as it will draw they same image just at higher res. But you can still see at the bottom of the image it will add weird stuff that weren't part of the original image, like extra heads or the concrete ground being transformed into weird architecture... |
I can confirm that highrez fix in img2img is not working. the minute you use 1024x1024 everything gets messed up. see attached images, exact same settings except resolution output |
I believe this issue is somewhat related to a bug report I made a few days ago #2841 |
Was this problem solved? I still get multibody or extra heads if I put resolution higher that 512x512. I tried to make input img 512x512 and change it to resolution I want - same effect. The only way to fix this includes much more steps that i need, and it means much more time. I need to make first a small resolution image and then adding 10% of noise every step, to get what should be done from the start. |
The option of Highres Fix. is missing SO very much I definitely agree. |
I don't have any knowledge of how the underlying system works, so if someone more knowledgeable could comment, it would be great. But if it isn't a dirty hack or requires a lot of code, I too would love to see the high res. fix option become available in img2img. |
High-res fix is needed for (inpainting) 100% |
I think the point here is that the steps are well known and can be automated but currently aren't for img2img. |
Any progress on this? This feature will be added? |
I'd also like to see this implemented. |
So, still no "Hires. fix" support in img2img ? |
I started to develop it today |
we always can typically upscaler is something that you set and forget about it but if you do want that you can add it yourself |
Yes, it's useful. I use this + inpaint-difference extension, to simulate hires fix for inpaint. And it can be used for img2img upscaling with no tilling. Much convenient then Ultimate SD / SD upscale if you don't use tiles |
I really think the highres fix is valuable for txt2image, and would love to see this option available for img2img as well. Thanks
The text was updated successfully, but these errors were encountered: