Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Support python 3.12 -> Upgrade torch to 2.2 #15270

Open
1 task done
LB22 opened this issue Mar 15, 2024 · 0 comments
Open
1 task done

[Feature Request]: Support python 3.12 -> Upgrade torch to 2.2 #15270

LB22 opened this issue Mar 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@LB22
Copy link

LB22 commented Mar 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

From the documentation here, Python 3.10.6 is the latest version compatible with torch.

This seems to have changed according to the closing of this issue, as torch 2.2.0 now supports Python 3.12.

Thus, upgrading the torch dependancy would allow us to use a newer version of python.

One potential caveat is that torch.compile is not yet supported as you can see here.

As I searched the code base I found no direct usage of torch.compile, but I did find something about SwinIR. Not sure if this is enough to block the upgrade?

I also do not know if any code would need to be updated as torch is upgraded, but perhaps this issue/thread can be used as ground for discussion.

Proposed workflow

  1. Upgrade torch dependency to v2.2.x
  2. ???
  3. Profit (newer python version compatibility)

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant