Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: X/Y/Z plot seed field should truncate last comma #14739

Closed
4 of 6 tasks
spotlesscoder opened this issue Jan 23, 2024 · 5 comments · Fixed by #14754
Closed
4 of 6 tasks

[Bug]: X/Y/Z plot seed field should truncate last comma #14739

spotlesscoder opened this issue Jan 23, 2024 · 5 comments · Fixed by #14754
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@spotlesscoder
Copy link

spotlesscoder commented Jan 23, 2024

Checklist

  • The issue exists after disabling all extensions
  • The issue exists on a clean installation of webui
  • The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • The issue exists in the current version of the webui
  • The issue has not been reported before recently
  • The issue has been reported before but has not been fixed yet

What happened?

Received error

ValueError: invalid literal for int() with base 10: ''

Steps to reproduce the problem

Made a x/y/z plot with seed as first field
Entered -1,-1,-1,-1, into the field (note the trailing comma)

What should have happened?

Trailing comma with no value after it is ignored (but stays in the input field so I can add a value at any time later

What browsers do you use to access the UI ?

No response

Sysinfo

Version 1.7.0
rest should not be relevant

Console logs

should not be relevant

Additional information

No response

@spotlesscoder spotlesscoder added the bug-report Report of a bug, yet to be confirmed label Jan 23, 2024
@w-e-w
Copy link
Collaborator

w-e-w commented Jan 24, 2024

you meant to say XYZ plot not Prompt matrix right

@spotlesscoder
Copy link
Author

@w-e-w yes, you are correct :)

@spotlesscoder spotlesscoder changed the title [Bug]: Prompt matrix seed field should truncate last comma [Bug]: X/Y/Z plot seed field should truncate last comma Jan 24, 2024
@w-e-w w-e-w linked a pull request Jan 24, 2024 that will close this issue
4 tasks
@koblue
Copy link

koblue commented Jan 25, 2024

This can actually be useful when using Prompt SR if you want to omit the thing you are changing as well as replace it.

for example

prmpt: Yellow Fire Truck

SR: Yellow, Red, Blue,

would get you: Yellow Fire Truck, Red Fire Truck, Blue Fire Truck, Fire Truck

I do depend on the trailing comma not being ignored like this, but I understand it not being wanted in other cases

Could we have it both ways, and have the option to ignore / not ignore the trailing comma in certain fields?

thx

@w-e-w
Copy link
Collaborator

w-e-w commented Jan 25, 2024

This can actually be useful when using Prompt SR

that is why my fix PR is only for number axis

@koblue
Copy link

koblue commented Jan 25, 2024

that is why my fix PR is only for number axis

so it is. :)

@w-e-w w-e-w closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants