Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate submitting a PR for digest update #643

Closed
algomaster99 opened this issue Nov 22, 2021 · 5 comments · Fixed by #644
Closed

Renovate submitting a PR for digest update #643

algomaster99 opened this issue Nov 22, 2021 · 5 comments · Fixed by #644

Comments

@algomaster99
Copy link
Member

algomaster99 commented Nov 22, 2021

Renovate submitted a #624 for updating actions/checkout to the latest commit. Let us prevent that. I configured what @slarse did here, but I am unsure why it wouldn't work. I found a comment relevant to this issue. We could try it even though the comment could be dated (it was posted on Nov'18).

The docs are a bit unclear because the options are just written in a list, and there is no explanation of how they are nested together.

EDIT: I found the schema: https://docs.renovatebot.com/renovate-schema.json.

@slarse
Copy link
Collaborator

slarse commented Nov 23, 2021

@algomaster99 @khaes-kth The only surefire way I've found to make Renovate behave like we want (i.e. use digests but pin to tag versions) is to add a comment on each line specifying a GitHub Action like so:

      - uses: actions/checkout@af513c7a016048ae468971c52ed77d9562c7c819 # renovate: tag=v1.0.0

See the docs here for info

The "helpers:pinGitHubActionDigests" has worked sporadically in Spoon, but it's been inconsistent.

In Spoon, we get updates like this: INRIA/spoon#4304. That's optimal, because we get the security of pinning to a digest, and the stability of pinning to specific tag versions.

@khaes-kth
Copy link
Collaborator

Interesting. What do you think @algomaster99 ? Should we give it a try?

@algomaster99
Copy link
Member Author

  - uses: actions/checkout@af513c7a016048ae468971c52ed77d9562c7c819 # renovate: tag=v1.0.0

@slarse I am not sure what this will do. Does pinning mean that renovate will never update the action beyond the major version specified in the tag? I think we want renovate to suggest update whenever a commit is tagged (a new release is out).

What do you think @algomaster99 ? Should we give it a try?

Yes, I am just trying to understand how renovate works. It is not clear to me what they say on the docs.

@slarse
Copy link
Collaborator

slarse commented Nov 29, 2021

I think we want renovate to suggest update whenever a commit is tagged (a new release is out).

This is what happens. See for example INRIA/spoon#4316

@algomaster99
Copy link
Member Author

The "helpers:pinGitHubActionDigests" has worked sporadically in Spoon, but it's been inconsistent.

So maybe we should not configure it for sorald. I can manually pin all the actions. It's a one-time task anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants