Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move query_jobs_by_status_code function from its-live-monitoring to HyP3 API/SDK #199

Open
jtherrmann opened this issue Nov 22, 2024 · 0 comments
Labels
Jira Task Create a Jira Task for this issue

Comments

@jtherrmann
Copy link
Contributor

jtherrmann commented Nov 22, 2024

Jira: https://asfdaac.atlassian.net/browse/TOOL-3320

Note: The above link is accessible only to members of ASF.


As part of #196 we're adding a new query_jobs_by_status_code function that queries the HyP3 jobs table directly. This means we have to add unit tests that use moto to mock the jobs table, which will need to be kept up-to-date with HyP3's jobs table architecture.

It would be better if both the query logic in query_jobs_by_status_code as well as the unit test mocking were moved to the HyP3 API (and then exposed via the SDK) so as not to spread internal knowledge about HyP3's database architecture across multiple repos.

Note that we had previously discussed moving the function to HyP3's dynamo library and then publishing the library, but decided against exposing HyP3's database in that manner, preferring to keep user interaction contained to the API.

@jtherrmann jtherrmann added the Jira Task Create a Jira Task for this issue label Nov 22, 2024
@jtherrmann jtherrmann changed the title Move query_jobs_by_status_code to HyP3's dynamo library Move query_jobs_by_status_code function to HyP3's dynamo library or hyp3_sdk Nov 22, 2024
@jtherrmann jtherrmann changed the title Move query_jobs_by_status_code function to HyP3's dynamo library or hyp3_sdk Move query_jobs_by_status_code function from its-live-monitoring to HyP3 API Dec 11, 2024
@jtherrmann jtherrmann changed the title Move query_jobs_by_status_code function from its-live-monitoring to HyP3 API Move query_jobs_by_status_code function from its-live-monitoring to HyP3 API/SDK Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Task Create a Jira Task for this issue
Projects
None yet
Development

No branches or pull requests

1 participant