Backport 2.16: add missing some error checks in ECP and bignum #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run all the addition and subtraction tests with the result aliased to the first operand and with the result aliased to the second operand. Before, only some of the aliasing possibilities were tested, for only some of the functions, with only some inputs. Signed-off-by: Gilles Peskine <[email protected]>
Fix a memory leak in mbedtls_mpi_sub_abs when the output parameter is aliased to the second operand (X = A - X) and the result is negative. Signed-off-by: Gilles Peskine <[email protected]>
fix_negative allocates memory for its result. The calling site didn't check the return value, so an out-of-memory error could lead to an incorrect calculation. Fix this. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
bug
needs-review
ronald-cron-arm
previously approved these changes
Sep 23, 2020
mpg
removed
the
needs-review
|
The CI only fails in (1) compat.sh in Travis which was fixed in the meantime by #3590 (2) armcc license issue, which is independent from this PR. |
|
I'm going to add a changelog entry, make the (trivial, I think) 2.7 backport, and rework #3512 to be standalone. |
gilles-peskine-arm
dismissed stale reviews from mpg and ronald-cron-arm
via
e16655c
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
force-pushed
the
ecp-bignum-error-checks-2.16
branch
from
e16655c to
3ce9480
Compare
gilles-peskine-arm
changed the title
gilles-peskine-arm
removed
the
needs-backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward backport of #3942