-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stm32: delete objects.h #13973
stm32: delete objects.h #13973
Conversation
@ladislas, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK... Issue was introduced during #12860
Could you also remove 2 other files ? :-)
targets/TARGET_STM/TARGET_STM32F7/TARGET_STM32F746xG/objects.h
targets/TARGET_STM/TARGET_STM32F7/TARGET_STM32F756xG/objects.h
b9e9509
to
eba8df7
Compare
@jeromecoutant ✅ and force pushed! |
Thanks @ladislas |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
When using cmake with DISCO_F769NI, compilation fails saying that
common_objects.h
is missing.I traced the issue back to the presence of this file:
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_STM/TARGET_STM32F7/TARGET_STM32F769xI/objects.h
Removing the file solves the issue.
Impact of changes
Fixes cmake with this target
Migration actions required
n/a
Documentation
n/a
Pull request type
Test results
Reviewers
@0xc0170 @hugueskamba @rajkan01 @jeromecoutant