Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake cellular: netsocket dependency #14414

Open
0xc0170 opened this issue Mar 11, 2021 · 2 comments
Open

CMake cellular: netsocket dependency #14414

0xc0170 opened this issue Mar 11, 2021 · 2 comments

Comments

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 11, 2021

Description of defect

See https://github.com/ARMmbed/mbed-os/blob/master/connectivity/cellular/CMakeLists.txt#L25

As I saw, cellular just needs ns_types.h (almost any networkign stack we have requires this, same is for nanostack). As ns_types.h is located in netsockets, we need to pull it in if we use cellular. Wouldn't it be better if that header is in separate module and netsockets/cellular/nanostack link to it ?

Target(s) affected by this defect ?

all

Toolchain(s) (name and version) displaying this defect ?

all

What version of Mbed-os are you using (tag or sha) ?

mbed-os-6.8.0

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

mbed-tools 7.0

How is this defect reproduced ?

Build mbed-os-example-cellular and investigate what code gets in (netsockets object files should be built).

@ciarmcom
Copy link
Member

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/IOTOSM-3575

@ladislas
Copy link
Contributor

Just hit this issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants