Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard include of RTE_Components.h with presence of _RTE_ #206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Guard include of RTE_Components.h with presence of _RTE_ #206

wants to merge 1 commit into from

Conversation

JonatanAntoni
Copy link
Member

@JonatanAntoni JonatanAntoni commented Nov 19, 2024 •
edited
Loading

Fixes #205, #200

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

Test Results

   240 files   -   132     240 suites   - 132   0s ⏱️ - 8m 51s
    56 tests +    7      54 ✅ + 11      2 💤  -     3  0 ❌  -   1 
12 948 runs   - 5 280  10 860 ✅  - 996  2 088 💤  - 4 176  0 ❌  - 108 

Results for commit c44f774. ± Comparison against base commit 783317a.

This pull request removes 49 and adds 56 tests. Note that renamed tests count towards both. 
CMSIS-Core.src ‑ apsr.c
CMSIS-Core.src ‑ basepri.c
CMSIS-Core.src ‑ bkpt.c
CMSIS-Core.src ‑ clrex.c
CMSIS-Core.src ‑ clz.c
CMSIS-Core.src ‑ control.c
CMSIS-Core.src ‑ cp15.c
CMSIS-Core.src ‑ cpsr.c
CMSIS-Core.src ‑ dmb.c
CMSIS-Core.src ‑ dsb.c
…

TC_CML1Cache_CleanDCacheByAddrWhileDisabled
TC_CML1Cache_EnDisableDCache
TC_CML1Cache_EnDisableICache
TC_CoreFunc_APSR
TC_CoreFunc_BASEPRI
TC_CoreFunc_Control
TC_CoreFunc_EnDisIRQ
TC_CoreFunc_EncDecIRQPrio
TC_CoreFunc_FAULTMASK
TC_CoreFunc_FPSCR
…
This pull request removes 5 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both. 
CMSIS-Core.src ‑ lda.c
CMSIS-Core.src ‑ ldaex.c
CMSIS-Core.src ‑ stl.c
CMSIS-Core.src ‑ stlex.c
CMSIS-Core.src ‑ systick.c

TC_CoreInstr_WFE
TC_CoreInstr_WFI

♻️ This comment has been updated with latest results.

RobertRostohar
RobertRostohar approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@RobertRostohar RobertRostohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Should we consider sticking with similar code style as in other files ?

  • space between defined and (
  • or no parenthesis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertRostohar RobertRostohar RobertRostohar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider to protect include "RTE_components.h" with _RTE_
2 participants
@JonatanAntoni @RobertRostohar