Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: nonsquare pooling functions #455

Closed
iabdalkader opened this issue Oct 19, 2018 · 4 comments
Closed

feature request: nonsquare pooling functions #455

iabdalkader opened this issue Oct 19, 2018 · 4 comments
Assignees

Comments

@iabdalkader
Copy link

Hi, I have a person detection network trained on 64x128 dataset, I used the nonsquare convolution functions but the pooling functions crash because they don't support nonsquare input. I would like to request nonsquare max/ave pooling functions to work with the nonsquare convolution functions. I implemented a slow (non-dsp version) nonsquare pooling, but a dsp version will be much appreciated. Thanks!

@saseptim
Copy link

As far as I can tell, the pooling function signature should be adjusted to include both x and y dimensions for pool, stride, pad, etc, and the code slightly adjusted such that dim_im_in should be changed to dim_im_in_x or dim_im_in_y as needed for example.

@majianjia
Copy link
Contributor

Same here. I am looking for 1D pooling, but finally, I have to make my own changes.
All I have done is copy and paste the original one and delete all the loop with the y-axis.
I believe you could modify it easily since the x and y are performed separately if you see the comments in the source

@kwagyeman
Copy link

Would be nice in ARM fixed this.

@felix-johnny
Copy link
Contributor

Unfortunately, I don't expect new deliveries on the non-TFLu compatible functions which this request falls into. If there is anything in the TFLu compatible(https://github.com/ARM-software/CMSIS_5/tree/develop/CMSIS/NN#legacy-vs-tfl-micro-compliant-apis) functions, please let us know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants