Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding embellish key in plot_grid #1229

Closed
wolfidan opened this issue Aug 3, 2022 · 3 comments
Closed

Question regarding embellish key in plot_grid #1229

wolfidan opened this issue Aug 3, 2022 · 3 comments

Comments

@wolfidan
Copy link
Contributor

wolfidan commented Aug 3, 2022

Dear Py-ART team,

In the plot_grid function, there is an embellish key.

It's specified that

embellish : bool
True by default. Set to False to supress drawinf of coastlines
etc... Use for speedup when specifying shapefiles.
Note that lat lon labels only work with certain projections.

When setting embellish=False, no country borders and coastlines are displayed which is fine and perfectly agrees with description, but the coordinates on the plot and the gridlines are not displayed either, which is a bit problematic (at least for me). I don't know if that was intended. Setting embellish=False is useful for the European users because the default geodata plotted by Py-ART are not so relevant for us, so it's easier for us to do it a-posteriori outside of Py-ART.

A very simple fix for that would be to unindent l.249 to 276 to put them outside of the embellish condition.
So embellish = False would mean no additional geodata is displayed but the plot still has gridlines and x and y ticks.

I would be happy to hear your opinion on this point..
Cheers,
Daniel W.

@zssherman
Copy link
Collaborator

Hmmm, I'm wondering too if they can be separated, embellish for coastlines etc, gridlines for the ticks etc. Having the gridlines included seems useful, but if there is any reason to not include, might be better to have a switch for them.

@wolfidan
Copy link
Contributor Author

wolfidan commented Aug 4, 2022

Thanks @zssherman, we could also imagine having two switches, one could be embellish to specify whether to plot the additional coastlines, countries, etc and the other could be display_georef (for example) which would trigger the display of the gridlines and the coordinates (xticks, yticks).

@zssherman
Copy link
Collaborator

Addressed in #1297 closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants