Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): only accept valid http path (SC http server) #3537

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Feb 26, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c8462e5). Click here to learn what that means.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3537   +/-   ##
=========================================
  Coverage          ?   66.11%           
=========================================
  Files             ?      439           
  Lines             ?    12472           
  Branches          ?     1714           
=========================================
  Hits              ?     8246           
  Misses            ?     4192           
  Partials          ?       34
Impacted Files Coverage Δ
packages/core-p2p/src/peer-connector.ts 67.44% <ø> (ø)
packages/core/src/commands/snapshot/rollback.ts 0% <0%> (ø)
packages/core/src/utils.ts 0% <0%> (ø)
packages/core-snapshots/src/manager.ts 0% <0%> (ø)
packages/crypto/src/transactions/serializer.ts 88.72% <100%> (ø)
packages/crypto/src/transactions/registry.ts 71.05% <100%> (ø)
packages/crypto/src/transactions/types/transfer.ts 100% <100%> (ø)
packages/crypto/src/transactions/types/schemas.ts 100% <100%> (ø)
...ges/crypto/src/transactions/types/multi-payment.ts 100% <100%> (ø)
packages/crypto/src/blocks/serializer.ts 83.67% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8462e5...11608af. Read the comment docs.

@faustbrian faustbrian merged commit f6462ef into master Feb 26, 2020
@ghost ghost deleted the fix/http-connection-master branch February 26, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants