Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make app.js optional as initially intended #3510

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Feb 17, 2020

Summary

Adds the app.js file to testnet and fixes the wrongly behaviour that the app.js file is required to be published. It was intended to be optional and fallback to the default app.js that core ships if it doesn't exist in the published configuration folder.

Can be tested with yarn global add @arkecosystem/[email protected].

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (2.6@bf16abd). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             2.6    #3510   +/-   ##
======================================
  Coverage       ?   66.12%           
======================================
  Files          ?      439           
  Lines          ?    12468           
  Branches       ?     1712           
======================================
  Hits           ?     8245           
  Misses         ?     4189           
  Partials       ?       34
Impacted Files Coverage Δ
packages/core/src/utils.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf16abd...a02fee8. Read the comment docs.

@faustbrian faustbrian merged commit 9f5785e into 2.6 Feb 19, 2020
@ghost ghost deleted the app-conf branch February 19, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant