Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypro): make deserializers static #3234

Merged
merged 1 commit into from
Nov 9, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Nov 8, 2019

Summary

Now it's consistent with the block/transaction Serializer classes.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #3234 into develop will increase coverage by 16.39%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3234       +/-   ##
============================================
+ Coverage    48.95%   65.35%   +16.39%     
============================================
  Files          429      429               
  Lines        12096    12096               
  Branches      1629     1629               
============================================
+ Hits          5922     7905     +1983     
+ Misses        6151     4157     -1994     
- Partials        23       34       +11
Impacted Files Coverage Δ
packages/crypto/src/blocks/block.ts 92.59% <100%> (ø) ⬆️
packages/crypto/src/transactions/deserializer.ts 92.52% <100%> (ø) ⬆️
packages/crypto/src/blocks/factory.ts 81.25% <100%> (ø) ⬆️
packages/crypto/src/blocks/deserializer.ts 92.18% <100%> (ø) ⬆️
packages/crypto/src/transactions/factory.ts 100% <100%> (ø) ⬆️
packages/core-p2p/src/network-monitor.ts 73.25% <0%> (+0.77%) ⬆️
packages/core-state/src/wallets/wallet-manager.ts 90.72% <0%> (+1.61%) ⬆️
packages/core-transaction-pool/src/memory.ts 98.66% <0%> (+2%) ⬆️
packages/core-transaction-pool/src/connection.ts 91.83% <0%> (+6.12%) ⬆️
packages/core-p2p/src/utils/is-valid-version.ts 100% <0%> (+7.14%) ⬆️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98522ea...ce8a113. Read the comment docs.

@faustbrian faustbrian merged commit 6250c0c into develop Nov 9, 2019
@ghost ghost deleted the refactor/crypto/deserializer branch November 9, 2019 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants