Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-database): set last height before initializing last block to use correct milestones #3109

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Oct 23, 2019

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #3109 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3109      +/-   ##
===========================================
- Coverage    65.71%   65.68%   -0.03%     
===========================================
  Files          425      425              
  Lines        11816    11821       +5     
  Branches      1618     1619       +1     
===========================================
  Hits          7765     7765              
- Misses        4015     4020       +5     
  Partials        36       36
Impacted Files Coverage Δ
packages/core-database/src/database-service.ts 26.01% <0%> (-0.45%) ⬇️
...ages/core-api/src/handlers/transactions/methods.ts 100% <0%> (ø) ⬆️
...s/core-api/src/handlers/shared/schemas/block-id.ts 100% <0%> (ø) ⬆️
packages/core-tester-cli/src/logger.ts 100% <0%> (ø) ⬆️
.../core-api/src/handlers/transactions/transformer.ts 100% <0%> (ø) ⬆️
packages/core-api/src/handlers/peers/schema.ts 100% <0%> (ø) ⬆️
...ackages/core-api/src/handlers/locks/transformer.ts 100% <0%> (ø) ⬆️
...kages/core-api/src/handlers/transactions/routes.ts 100% <0%> (ø) ⬆️
...kages/core-tester-cli/src/commands/debug/verify.ts 100% <0%> (ø) ⬆️
...ackages/core-api/src/handlers/businesses/schema.ts 100% <0%> (ø) ⬆️
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd4abc...7d71f8c. Read the comment docs.

@faustbrian faustbrian merged commit 3f80f38 into develop Oct 23, 2019
@ghost ghost deleted the fix/core-database/init branch October 23, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants