Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transactions): throw if transaction key is already taken #3095

Merged
merged 2 commits into from
Oct 22, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Oct 22, 2019

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #3095 into develop will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3095      +/-   ##
===========================================
- Coverage    65.72%   65.71%   -0.01%     
===========================================
  Files          425      425              
  Lines        11812    11816       +4     
  Branches      1617     1618       +1     
===========================================
+ Hits          7763     7765       +2     
- Misses        4013     4015       +2     
  Partials        36       36
Impacted Files Coverage Δ
packages/crypto/src/errors.ts 80% <50%> (-1.14%) ⬇️
packages/crypto/src/transactions/registry.ts 70.27% <50%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651cf16...1ed8cc8. Read the comment docs.

@faustbrian faustbrian merged commit 24a955b into develop Oct 22, 2019
@ghost ghost deleted the fix/core-transactions/ensure-unique-key branch October 22, 2019 06:04
vasild added a commit that referenced this pull request Oct 22, 2019
* ArkEcosystem/core/develop:
  fix(core-transactions): throw if transaction key is already tak… (#3095)
  refactor(core-api): format timestamp of locks (#3091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants