-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(crypto): replace bignumber.js with native BigInt #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Medium
labels
Oct 2, 2019
spkjp
changed the title
perf(crypto): replace bignumber.js with native bigint
perf(crypto): replace bignumber.js with native BigInt
Oct 2, 2019
Codecov Report
@@ Coverage Diff @@
## develop #3010 +/- ##
===========================================
+ Coverage 66.03% 66.05% +0.01%
===========================================
Files 423 423
Lines 10120 10131 +11
Branches 538 539 +1
===========================================
+ Hits 6683 6692 +9
- Misses 3392 3394 +2
Partials 45 45
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Oct 3, 2019
ghost
deleted the
perf/crypto/native-bigint
branch
October 3, 2019 05:46
vasild
added a commit
that referenced
this pull request
Oct 4, 2019
…ts-nonce * ArkEcosystem/core/develop: refactor: remove `vendorFieldHex` (#3014) ci: run push events on master and develop, rest on PRs perf(crypto): memoize base58 de/encoding (#3015) refactor(core-transactions): bootstrap transactions in batches (#2997) perf(crypto): replace bignumber.js with native BigInt (#3010) refactor: add `round.missed` event (#3011)
ghost
mentioned this pull request
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
bignumber.js
with our own thin wrapper around the native BigInt type. Depends on some yet unreleased@arkecosystem/utils
fixes. With native BigInts the memory usage of my node is about 10% less after bootstrap compared to without this PR.Benchmarks before:
After:
Checklist