Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-blockchain): break loop if block contains v1 transaction #2914

Merged
merged 3 commits into from
Sep 12, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Sep 10, 2019

We already call blockContainsIncompatibleTransactions which ensures that a block cannot contain mixed versions. So it is safe to assume that all following transactions are the same.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

Merging #2914 into develop will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2914   +/-   ##
========================================
  Coverage    68.13%   68.13%           
========================================
  Files          406      406           
  Lines         9774     9774           
  Branches       466      466           
========================================
  Hits          6660     6660           
  Misses        3076     3076           
  Partials        38       38
Impacted Files Coverage Δ
...s/core-blockchain/src/processor/block-processor.ts 85.45% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2edcd53...d12607e. Read the comment docs.

@faustbrian faustbrian merged commit 0c89e4a into develop Sep 12, 2019
@ghost ghost deleted the refactor/core-blockchain/exit-loop-early branch September 12, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants