Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(core-p2p): accept prerelease version #2911

Merged
merged 3 commits into from
Sep 5, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Sep 5, 2019

Removes the need to mess with minimumVersions on devnet.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Sep 5, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@spkjp spkjp changed the title miscc(core-p2p): accept prerelease version misc(core-p2p): accept prerelease version Sep 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #2911 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2911      +/-   ##
===========================================
+ Coverage    68.06%   68.07%   +<.01%     
===========================================
  Files          405      405              
  Lines         9752     9754       +2     
  Branches       506      506              
===========================================
+ Hits          6638     6640       +2     
  Misses        3073     3073              
  Partials        41       41
Impacted Files Coverage Δ
packages/core-p2p/src/utils/is-valid-version.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00735d...13644bd. Read the comment docs.

@spkjp spkjp merged commit 59183bf into develop Sep 5, 2019
@ghost ghost deleted the misc/core-p2p/include-prerelease-version branch September 5, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants