Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport bug fixes to master #2907

Merged
merged 5 commits into from
Sep 4, 2019
Merged

Backport bug fixes to master #2907

merged 5 commits into from
Sep 4, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Sep 4, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Sep 4, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ghost ghost added the Complexity: Medium label Sep 4, 2019
@faustbrian faustbrian merged commit a52ed70 into master Sep 4, 2019
@ghost ghost deleted the backport branch September 4, 2019 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants