refactor(core-state): wallet model cleanup #2839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the wallet model and moves almost all of the existing wallet properties into a private
attributes
object.Whenever the wallet model had to be extended we'd introduce a new property. This bloated the entire class with no clear semantic structure. With more and more transaction types coming up. this becomes even more of an issue.
The new approach to interface with (custom) wallet data is by using the following set of functions:
Internally it is using
dottie
to support access based on a property path.This PR is quite pervasive and will break at least all existing custom transactions and #2773.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
develop
branch, not themaster
branchIf adding a new feature, the PR's description includes: