feat: batch block database inserts when syncing #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
The ci/circleci: test-node10-e2e job is failing as of c59d771ea7478f037c6e774549ddb695cd39fdae. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
faustbrian
reviewed
Apr 29, 2019
| } catch (exceptionSaveBlocks) { | ||
| logger.error(`Could not save ${acceptedBlocks.length} blocks to database : ${exceptionSaveBlocks.stack}`); | ||
|
|
||
| const resetToHeight = async height => { |
There was a problem hiding this comment.
Suggested change
| const resetToHeight = async height => { | |
| const resetToHeight = async height => { | |
| try { | |
| return await this.removeTopBlocks( | |
| app | |
| .resolvePlugin<State.IStateService>("state") | |
| .getStore() | |
| .getLastHeight() - height, | |
| ); | |
| } catch (e) { | |
| logger.error(`Could not remove top blocks from database : ${e.stack}`); | |
| return resetToHeight(height); // keep trying, we can't do anything while this fails | |
| } | |
| }; |
faustbrian
reviewed
Apr 29, 2019
| * @param {Function} callback | ||
| * @return {(Function|void)} | ||
| */ | ||
| processBlock(block: Interfaces.IBlock, callback: any): Promise<any>; | ||
| processBlocks(block: Interfaces.IBlock[], callback: any): Promise<any>; |
There was a problem hiding this comment.
Suggested change
| processBlocks(block: Interfaces.IBlock[], callback: any): Promise<any>; | |
| processBlocks(blocks: Interfaces.IBlock[], callback: any): Promise<any>; |
faustbrian
reviewed
Apr 29, 2019
| } | ||
|
|
||
| try { | ||
| // save accepted blocks to db |
There was a problem hiding this comment.
Comment can be removed.
faustbrian
reviewed
Apr 29, 2019
| // broadcast only current block | ||
| const blocktime: number = config.getMilestone(block.data.height).blocktime; | ||
| const blocktime: number = config.getMilestone(blocks[blocks.length - 1].data.height).blocktime; |
There was a problem hiding this comment.
Store blocks[blocks.length - 1] in a variable named currentBlock so it is more clear what the value is.
faustbrian
approved these changes
Apr 29, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Batch block database inserts. Resolves #1945.
Did some benchmark for testnet sync (on potato server) : 7-8min to sync to 540k blocks vs a bit more than 20min non-batching.
What kind of change does this PR introduce?
Does this PR release a new version?
Checklist